docs: note that the prototypes do not build with the current public toolchain - #11
Open
memosr wants to merge 1 commit into
Open
docs: note that the prototypes do not build with the current public toolchain#11memosr wants to merge 1 commit into
memosr wants to merge 1 commit into
Conversation
…oolchain The README tells readers to cd into a prototype and run `sforge test`, but that command fails on all five prototypes with the public toolchain: ssolc 0.8.31 rejects shielded types as mapping keys (Error 10109), and every prototype declares `mapping(saddress => ...)` (17 occurrences across 8 files). CI builds sforge from a local checkout (SFOUNDRY_ROOT=/home/azureuser/...), so the failure is not visible from the maintainer side. This only documents the current state and links the tracking issue; it does not touch any contract. The mapping-key question itself is a design decision for the team (see SeismicSystems#10).
|
Confirmed the diff matches what I verified independently - just the README note, no contract changes, and the counts (17 occurrences / 8 files) line up. Clean, low-risk fix that helps new clones fail loudly instead of silently. LGTM from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10, documentation only.
The README currently tells readers to
cdinto a prototype and runsforge test. That command fails on all five prototypes with the public toolchain:ssolc 0.8.31rejects shielded types as mapping keys (Error 10109), and every prototype declaresmapping(saddress => ...).Verified against
mainHEAD:CI builds
sforgefrom a local checkout (SFOUNDRY_ROOT=/home/azureuser/prototypes/seismic-foundry), which is likely why this is not visible from the maintainer side.This PR only records the current state and links the tracking issue. It does not touch any contract, and it does not presuppose any answer to the mapping-key design question in #10, which is still yours to make.
If you would rather fix the prototypes than document the breakage, I am happy to close this and open that PR instead once the team decides whether account-membership privacy is load-bearing here.
cc @ygd58, who reproduced the same failure independently.