ci: run flow's checks on GitHub-hosted runners - #2
Merged
Conversation
The upstream `test` and `typecheck` workflows target Blacksmith runners registered to the upstream organisation. This fork has no runners with those labels, so every job queues until GitHub cancels it 24 hours later: no run in this repository's history has ever completed, and the green checks the default branch appears to want have never existed. Adds a fork-owned workflow on `ubuntu-latest` and `windows-latest` that typechecks and unit-tests `packages/flow`, the only package this fork changes. New file rather than an edit to the upstream workflows, so merging upstream stays clean.
Windows checkout failed before it wrote a tree: the repository carries symlinks whose targets exceed Windows' 260-character default, so git refused them with "Filename too long". Enable `core.longpaths` before checkout runs. The `browseDirectory` root test asserted `path` and `parent` are null for an omitted target, which is only true on Windows — there is no single root there, so the drive list is its own level. On every other platform the call lists `/`, which is a real directory that reports itself as its own parent. The test now expects each platform's actual contract instead of Windows' alone. Both were invisible until now: no job in this repository had ever reached a runner.
Two files upstream carry symlink mode with a whole source file as their target, which Windows git cannot materialise at all. Long paths alone was not enough — it turned "Filename too long" into "Result too large". Disabling core.symlinks for the checkout writes them as ordinary files; no job here reads them.
The job-level env block used the runner context, which only exists at step scope, so the workflow failed to compile and produced no jobs at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream
testandtypecheckworkflows target Blacksmith runners registered to the upstream organisation. This fork has no runners with those labels, so every job queues until GitHub cancels it 24 hours later — no run in this repository's history has ever completed.Adds a fork-owned workflow on
ubuntu-latestandwindows-latestthat typechecks and unit-testspackages/flow, the only package this fork changes. New file rather than an edit to the upstream workflows, so merging upstream stays clean.This PR is also the first real proof: the
flow (ubuntu-latest)andflow (windows-latest)checks below are the first jobs in this repository to reach a runner.🤖 Generated with Claude Code