Repository navigation
Document the production deployment approval gate - #129
Merged
Merged
Conversation
The production GitHub environment now requires a reviewer, so a v* tag runs the tests and then waits for Jason's approval before flyctl deploy. RELEASE.md, docs/operations.md and AGENTS.md say so, and tell an agent to report the waiting run rather than approve it. Assisted-by: Claude Fable 5.1
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
productionenvironment got a required reviewer on 2026-10-17. From now on av*tag runs the tests and then pauses at "Review deployments" until Jason approves it. This records that in the three places that described the deploy as fully automatic:RELEASE.md: the shape section, a new step 4 (approve), and a note that a rollback goes through the same gate.docs/operations.md: the CI/CD bullet and themake releasecomment.AGENTS.md: the release convention, plus "never approve a deployment".Docs only.
make verifypasses.