Skip to content

fix(types): preserve estree printer key - #188

Merged
Sec-ant merged 1 commit into
mainfrom
fix/type-issues
Oct 20, 2026
Merged

Sec-ant merged 1 commit into
mainfrom
fix/type-issues

Conversation

@Sec-ant

@Sec-ant Sec-ant commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Preserve the estree key in the generated printer declaration.

Fixes #186

Summary by CodeRabbit

  • Bug Fixes

    • Preserved the estree printer key in the published type definitions.
  • Type Improvements

    • Improved validation of the exported printer configuration without changing its runtime behavior.

@changeset-bot

changeset-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f560073

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prettier-plugin-embed Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7239904b-ea33-442c-88a6-a37246cfbd16
📥 Commits

Reviewing files that changed from the base of the PR and between 6617ea4 and f560073.

📒 Files selected for processing: 2
  • .changeset/tidy-printers-keep-key.md
  • src/printers.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The exported printers object now uses inferred typing validated against Plugin["printers"]. A patch changeset documents preservation of the estree printer key in the published type.

Changes: Printer typing

Layer / File(s) Summary
Infer and validate printer type
src/printers.ts, .changeset/tidy-printers-keep-key.md
printers now uses satisfies Plugin["printers"] instead of an explicit type annotation. The estree printer composition and embed implementation are unchanged. The patch changeset documents preservation of the estree printer key in the published type.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to f5600

The focused typing change and patch changeset present no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: preserving the estree printer key in generated types.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 20, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/prettier-plugin-embed@188

commit: f560073

@Sec-ant
Sec-ant merged commit 42ed572 into main Oct 20, 2026
8 checks passed
@Sec-ant
Sec-ant deleted the fix/type-issues branch October 20, 2026 05:51

This branch was successfully deployed

1 active deployment
github-pages — f5600730 Deployed Oct 20, 2026 by Sec-ant via deploy #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep the estree key in the printers export type

1 participant