Add prefix option to nested attribute in FromQueryResult and PartialModel#2989
Open
YouKnow-sys wants to merge 4 commits intoSeaQL:masterfrom
Open
Add prefix option to nested attribute in FromQueryResult and PartialModel#2989YouKnow-sys wants to merge 4 commits intoSeaQL:masterfrom
prefix option to nested attribute in FromQueryResult and PartialModel#2989YouKnow-sys wants to merge 4 commits intoSeaQL:masterfrom
Conversation
YouKnow-sys
force-pushed
the
nested-prefix-attribute
branch
from
e2a85e4 to
8a7c868
Compare
YouKnow-sys
force-pushed
the
nested-prefix-attribute
branch
from
8a7c868 to
0b67194
Compare
Expurple
reviewed
Mar 26, 2026
Comment on lines
748
to
+752
| /// #[sea_orm(nested)] | ||
| /// baker: Option<cakes_bakers::Model>, | ||
| /// // prefix is optional, useful when multiple fields share the same type | ||
| /// #[sea_orm(nested(prefix = "reviewer_"))] | ||
| /// reviewer: Option<cakes_bakers::Model>, |
Member
There was a problem hiding this comment.
Can we add a codegen test for this?
Author
There was a problem hiding this comment.
I added tests to partial_model, should I also add some test to the tests/partial_model_nested/nested_alias.rs and tests/from_query_result_tests.rs as well? seem unnecessary because the logic is clear, but if needed I can do it.
Member
There was a problem hiding this comment.
Haha, I meant asserting the generated SQL query. Probably in a doctest. We have many examples of that in the codebase. Sorry for being unclear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
prefixsupport toFromQueryResultnestedattribute #2981New Features
#[sea_orm(nested(prefix = "..."))]forFromQueryResultandPartialModelderives.Bug Fixes
before this change having two nested model with same type will silently have unexpected behavior.
Breaking Changes
nothing, unless user depends on two field of same nested model have exactly same value... which is wrong behavior to begin with.
Changes
get_list_args helpertoGetMetatrait for parsing list-style attributes.syn::Errorinstead of custom Error enum inFromQueryResultderive for better error spans. (tbh we should do this for all other derive macros, but that's for another PR)