[codex] Fix code diagnostics LSP startup states#145
Draft
ScriptedAlchemy wants to merge 3 commits into
Draft
Conversation
|
c87d758 to
9a3e2f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The stdio LSP client discarded stderr and surfaced "closed before initialize response" when the rustup proxy exited early. The diagnostics broker then classified all refresh failures as crashed, so a missing or unavailable rust-analyzer binary appeared as a crash. Separately, dashboard document selection was extension-only, which could activate language servers for files that did not represent a real project for that adapter.
Impact
Rust analyzer failures now report the actionable rustup/toolchain stderr and are classified as unavailable instead of crashed. Language servers are only activated when project signals indicate they are needed, which reduces noisy startup attempts and makes Code Diagnostics state match the actual repository.
Validation
cargo nextest run --test lsp_code_diagnostics_test --no-fail-fastcargo nextest run --test dashboard_code_diagnostics_api_test --no-fail-fastcargo nextest run documents_for_adapter --no-fail-fastcd dashboard && npm run test:nodecd dashboard && npm run test:dom