Use Dynamic Routes#268
Open
ScriptRaccoon wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #193, which unified the Svelte components and pages for categories and functors. The routes, and therefore the folder structure in
/routes, were still duplicated. This became apparent after adding morphisms in #265. This PR addresses the issue by using dynamic routes instead, which are sufficiently flexible in SvelteKit.Example
For example, instead of three folders with almost identical logic:
there is now a single folder that handles all three cases:
The same approach applies to other type-specific routes. This change will become even more beneficial in the future when additional structure types (such as monoidal categories) are added.
Breaking change
The route listing all categories has changed from
/categoriesto/category-list. Similar changes apply to functors and morphisms. In general, all routes associated with a specific type now start with/[type], and plural forms are no longer used.