fix: resolve broken test imports causing pytest collection errors#1044
Open
KhadyotTakale wants to merge 1 commit intoScrapeGraphAI:pre/betafrom
Open
fix: resolve broken test imports causing pytest collection errors#1044KhadyotTakale wants to merge 1 commit intoScrapeGraphAI:pre/betafrom
KhadyotTakale wants to merge 1 commit intoScrapeGraphAI:pre/betafrom
Conversation
- Replace removed ScrapeGraph with SmartScraperGraph in scrape_graph_test.py - Replace renamed convert_to_csv/convert_to_json with export_to_csv/export_to_json in xml_scraper_openai_test.py
dosubot
bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two test files fail during
pytestcollection due to stale imports, preventing the full test suite from running:tests/graphs/scrape_graph_test.py— importsScrapeGraphwhich no longer existstests/graphs/xml_scraper_openai_test.py— importsconvert_to_csv/convert_to_jsonwhich were renamedChanges
ScrapeGraphwithSmartScraperGraphand added the requiredpromptparameterconvert_to_csv/convert_to_jsonwithexport_to_csv/export_to_jsonVerification
pytest --collect-onlynow collects 270 tests with 0 errors (previously 2 collection errors).