Skip to content

Use placeholder tip bot wallet in env example#7484

Open
z272258483 wants to merge 1 commit into
Scottcjn:mainfrom
z272258483:fix/env-example-tip-wallet-placeholder
Open

Use placeholder tip bot wallet in env example#7484
z272258483 wants to merge 1 commit into
Scottcjn:mainfrom
z272258483:fix/env-example-tip-wallet-placeholder

Conversation

@z272258483

Copy link
Copy Markdown

Summary

  • replace the real-format TIP_BOT_WALLET value in .env.example with an explicit placeholder
  • add a short note telling deployers to provide their own public RTC wallet address

Validation

  • rg -n "TIP_BOT_WALLET|RTC[0-9a-fA-F]{40}" .env.example
  • git diff --check

Closes #7483

@github-actions

Copy link
Copy Markdown
Contributor

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Non-doc PRs have a BCOS-L1 or BCOS-L2 label
  • Doc-only PRs are exempt from BCOS tier labels when they only touch docs/**, *.md, or common image/PDF files
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

@Monster5860 Monster5860 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the change and it looks correct to me. I checked the only indexed uses of TIP_BOT_WALLET: the example file and .github/workflows/tip-bot.yml. The workflow reads TIP_BOT_WALLET from GitHub Secrets, not from .env.example, so replacing the example value with a non-address placeholder should not affect tip-bot execution. The new comment also makes the deployment action explicit for operators and reduces the risk that someone copies a real-looking wallet value from the sample config into production by mistake.\n\nValidation performed:\n- inspected the PR diff for .env.example\n- searched repository code for TIP_BOT_WALLET usages\n- checked that the tip-bot workflow sources the value from secrets.TIP_BOT_WALLET\n\nVerdict: approve as a focused config-safety/docs change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] .env.example ships a real wallet address in TIP_BOT_WALLET — template should be a placeholder

2 participants