Skip to content

Unit tests for MeshIndexSet. - #7219

Merged
stephenworsley merged 16 commits into
SciTools:FEATURE_index_setfrom
trexfeathers:index-set-unit-tests
Jul 27, 2026
Merged

Unit tests for MeshIndexSet.#7219
stephenworsley merged 16 commits into
SciTools:FEATURE_index_setfrom
trexfeathers:index-set-unit-tests

Conversation

@trexfeathers

@trexfeathers trexfeathers commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is best understood by comparing to other metadata tests such as test_MeshMetadata.py 1

Footnotes

  1. the only differences should be resulting from the different memberships, and possibly some slight ordering differences.

@trexfeathers trexfeathers Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should have a more thorough parameterisation of the three locations
  • Should test whether the original MeshXY is all lazy connectivities/coords versus all NumPy versions

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.42%. Comparing base (43b82f2) to head (b9b9214).
⚠️ Report is 5 commits behind head on FEATURE_index_set.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           FEATURE_index_set    #7219      +/-   ##
=====================================================
+ Coverage              89.86%   90.42%   +0.56%     
=====================================================
  Files                     92       93       +1     
  Lines                  25573    25818     +245     
  Branches                4768     4795      +27     
=====================================================
+ Hits                   22980    23346     +366     
+ Misses                  1789     1693      -96     
+ Partials                 804      779      -25     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread lib/iris/tests/unit/mesh/components/test_MeshIndexSet.py Outdated
Comment thread lib/iris/tests/unit/common/metadata/test_MeshIndexSetMetadata.py Outdated
Comment thread lib/iris/tests/unit/mesh/components/test_MeshCoord.py
Comment thread lib/iris/tests/unit/mesh/components/test_MeshIndexSet.py Outdated
Comment thread lib/iris/tests/unit/mesh/components/test_MeshIndexSet.py Outdated
Comment thread lib/iris/tests/unit/mesh/components/test_MeshIndexSet.py
Comment thread lib/iris/tests/unit/mesh/components/test_MeshIndexSet.py

@stephenworsley stephenworsley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My remaining concerns about test coverage (see here) would be better addressed in the integration tests.

@trexfeathers
trexfeathers marked this pull request as ready for review July 27, 2026 12:42
@stephenworsley
stephenworsley merged commit 6f47a87 into SciTools:FEATURE_index_set Jul 27, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants