ruff compliance for TC#7203
Conversation
There was a problem hiding this comment.
Templating
This PR includes changes that may be worth sharing via templating. For each file listed below, please either:
- Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github
templates/directory. 1 - Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
- Dismiss the suggestion if the changes are not suitable for templating.
You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.
Templated files
The following changed files are templated:
-
pyproject.toml, templated bySciTools/.github/templates/pyproject.toml
Footnotes
-
Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
@scitools-templating: please no update notification on: iris↩
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7203 +/- ##
==========================================
+ Coverage 90.18% 90.34% +0.16%
==========================================
Files 91 92 +1
Lines 25102 25335 +233
Branches 4706 4731 +25
==========================================
+ Hits 22638 22889 +251
+ Misses 1685 1675 -10
+ Partials 779 771 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Maybe this could be included in the template. Almost all issues can be fixed automatically by ruff, so the amount of work for adoption would be minimal. |
I don't think this should be templated;
I believe the precedent we agreed upon when creating the templates is that we don't expect everyone to progress Ruff checks at the same speed, and so we'll leave everything ignored until the project leads get around to it.
I'll double check this with the team, and if I'm mistaken I'll adjust the template myself at a later date.
ESadek-MO
left a comment
There was a problem hiding this comment.
Thanks @bouweandela, all looks good to me, just one problem with the WhatsNew.
Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com>
ESadek-MO
left a comment
There was a problem hiding this comment.
Thanks, look good now!
Description
Enable the ruff type checking rules. These rules are convenient because they allow automatically formatting the imports in such a way that circular dependencies from adding type hints are avoided.
#5625
Checklist
Important
The Iris core developers are here to help! If anything below is unclear, just post a comment asking for help 😊
(further reading)
Tip
Things you can trigger on this PR:
9999for this PR's number - to re-trigger the CLA check:https://cla-assistant.io/check/SciTools/iris?pullRequest=9999