GTR-13432 (Handle multiple Twilio error codes in call handling)

[adenchen123]

No description provided.

[qodo-code-review]

PR Summary by Qodo

Handle Twilio call-blocking errors and stop completion

🐞 Bug fix 🕐 Less than 10 minutes

AI Description

• Handle Twilio error codes 21215 and 21216 as blocked outbound calls.
• Stop further model completion after returning the user-facing call restriction message.

Diagram

graph TD
  A["Outbound handler"] --> B["Twilio API"] --> C{"Call outcome?"}
  C -->|21215 or 21216| D["Restriction message"] --> E["Stop completion"]
  C -->|Queued| F["Conversation fork"]
  C -->|Other| G["Existing failure path"]

Loading

High-Level Assessment

The centralized HashSet and filtered catch are appropriate for a small, extensible list of equivalent Twilio restriction codes. A direct pattern-match condition would be shorter for two codes but less convenient as the supported set grows.

Files changed (1) +5 / -3

Bug fix (1) +5 / -3

OutboundPhoneCallFn.csHandle multiple blocked-call errors and halt completion +5/-3

Handle multiple blocked-call errors and halt completion

• Replaces the single geo-permission error constant with a set containing Twilio codes 21215 and 21216. Matching API exceptions now return the existing restriction message and set 'StopCompletion' to prevent further execution.

src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/Functions/OutboundPhoneCallFn.cs

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗