optimze crontab identity#1378
Open
yileicn wants to merge 3 commits into
Open
Conversation
Contributor
PR Summary by QodoFix crontab hook identity propagation across HookEmitter async boundaries
AI Description
Diagram
High-Level Assessment
Files changed (6)
|
Contributor
Code Review by Qodo
1. Case-sensitive Triggers.Contains match
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+136
to
+148
| HookEmitter.Emit<ICrontabHook>(_services, hook => | ||
| { | ||
| if (hook.Triggers == null || hook.Triggers.Contains(item.Title)) | ||
| { | ||
| hook.OnAuthenticate(item); | ||
| } | ||
| }, item.AgentId); | ||
|
|
||
| // Phase 2 - Execute. | ||
| await HookEmitter.Emit<ICrontabHook>(_services, async hook => | ||
| { | ||
| if (hook.Triggers == null || hook.Triggers.Contains(item.Title)) | ||
| { |
Contributor
There was a problem hiding this comment.
1. Case-sensitive triggers.contains match 📘 Rule violation ≡ Correctness
hook.Triggers.Contains(item.Title) uses default (case-sensitive/culture-sensitive) string equality, which can break identifier-like trigger matching when casing differs. This violates the requirement to use ordinal, case-insensitive comparisons/collections for identifier lookups.
Agent Prompt
## Issue description
`ScheduledTimeArrived` matches triggers using `hook.Triggers.Contains(item.Title)` which is case-sensitive by default. The compliance requirement is to use ordinal, case-insensitive comparisons for identifier-like strings.
## Issue Context
This PR introduced/rewrote the trigger-filtering logic in `ScheduledTimeArrived` (now executed in two phases), and the trigger match is performed in both phases.
## Fix Focus Areas
- src/Infrastructure/BotSharp.Core.Crontab/Services/CrontabService.cs[136-148]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+136
to
151
| HookEmitter.Emit<ICrontabHook>(_services, hook => | ||
| { | ||
| if (hook.Triggers == null || hook.Triggers.Contains(item.Title)) | ||
| { | ||
| hook.OnAuthenticate(item); | ||
| } | ||
| }, item.AgentId); | ||
|
|
||
| // Phase 2 - Execute. | ||
| await HookEmitter.Emit<ICrontabHook>(_services, async hook => | ||
| { | ||
| if (hook.Triggers == null || hook.Triggers.Contains(item.Title)) | ||
| { | ||
| await hook.OnTaskExecuting(item); | ||
| await hook.OnCronTriggered(item); | ||
| await hook.OnTaskExecuted(item); |
Contributor
There was a problem hiding this comment.
2. Hook instances may differ 🐞 Bug ≡ Correctness
ScheduledTimeArrived now resolves ICrontabHook implementations twice (once for Phase 1 auth, again for Phase 2 execution); if any hook is registered as transient, OnAuthenticate can run on a different instance than OnCronTriggered, breaking per-hook state that was initialized during authentication.
Agent Prompt
## Issue description
`CrontabService.ScheduledTimeArrived` performs two separate `HookEmitter.Emit` calls, which re-resolve hooks from DI each time. This can produce different hook instances for transient lifetimes, causing `OnAuthenticate` state to be lost before `OnTaskExecuting/OnCronTriggered/OnTaskExecuted`.
## Issue Context
- Today, the known `ICrontabHook` registrations in-repo are `AddScoped`, so this may not reproduce right now, but the contract doesn’t enforce that and plugins can introduce transient hooks.
## Fix Focus Areas
- Resolve the hook list once and reuse it for both phases (or add an overload that accepts an already-resolved hook list).
- file: src/Infrastructure/BotSharp.Core.Crontab/Services/CrontabService.cs[129-153]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.