Sync with upstream v299 #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure workflow uses same bundler version * Fix test
Signed-off-by: Pablo Temporini <ptemporini@salesforce.com>
* Add Heroku YAML report builder This utility class writes a yaml file for capturing observability metrics. * Add Ruby version metrics to global report * Implement bin/report * Report bundler version * Observe railties and rack versions * Changelog * Document error tolerance behavior * Update captured ruby version information * Fix tests * Document RubyVersion accessors * Cleaner major ruby version * Remove unused legacy ruby logic We no longer provide Ruby 1.9.2 * Silence warnings
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
The `bin/report` structure is flat. All keys must map to values that are un-nested. Ruby's `to_yaml` will happily serialize ruby objects:
```
irb(main):004> puts Gem::Version.new("3.4.2").to_yaml
--- !ruby/object:Gem::Version
version: 3.4.2
```
This commit fixes this problem by inspecting if the value being serialized is an object or not. If it is, it is then converted into a string.
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
EtienneM
approved these changes
Apr 9, 2025
Comment on lines
+6
to
+7
| ## [v299] - 2025-04-07 | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #104