Conversation
examples/cluster_config.yml had no environment section, so a reader had no hint that the role takes no cluster_instance and relies on SC_HOST / SC_USERNAME / SC_PASSWORD. Add a commented play-level block and say why it belongs at play level (environment on include_role does not reach the role's tasks). examples/iso_info.yml wrote its commented SC_* entries as list items under a mapping; uncommented as written that is invalid YAML. Refs #380 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #380 (the examples part only; role READMEs and
action_groupsremain open there).examples/cluster_config.yml: add a commented play-levelenvironment:block withSC_HOST/SC_USERNAME/SC_PASSWORD, and explain that the role takes nocluster_instanceand thatenvironmentmust be at play level (on aninclude_roletask it does not reach the role's tasks). Left commented so the existing "export in your shell" workflow fromexamples/README.mdkeeps working unchanged.examples/iso_info.yml: the commentedSC_*entries were list items (# - SC_HOST: ...) under a mapping; uncommented as written they are invalid YAML. Now plain mapping keys.Comment-only changes. Verified locally that both files parse as-is and with the environment lines uncommented, and that the old
iso_infoform fails to parse when uncommented.ansible-playbook --syntax-checkpasses oncluster_config.yml.CI is currently offline, so no green checks expected.
🤖 Generated with Claude Code