Wrap default values in a struct

[ds5678]

This ensures that we properly distinguish the constant null from having no default value at all.

[coveralls]

Coverage Report for CI Build 29700142382

Coverage increased (+0.04%) to 37.803%

Details

• Coverage increased (+0.04%) from the base build.
• Patch coverage: 10 uncovered changes across 6 files (55 of 65 lines covered, 84.62%).
• 2 coverage regressions across 2 files.

Uncovered Changes

File	Changed	Covered	%
Cpp2IL.Core/Model/Contexts/ConcreteGenericFieldAnalysisContext.cs	2	0	0.0%
Cpp2IL.Core/Model/Contexts/ConcreteGenericParameterAnalysisContext.cs	2	0	0.0%
Cpp2IL.Core/Model/Contexts/ParameterAnalysisContext.cs	16	14	87.5%
LibCpp2IL/Reflection/Il2CppParameterReflectionData.cs	2	0	0.0%
Cpp2IL.Core/Model/Contexts/InjectedParameterAnalysisContext.cs	3	2	66.67%
Cpp2IL.Core/ProcessingLayers/StableRenamingProcessingLayer.cs	1	0	0.0%
Total (17 files)	65	55	84.62%

Coverage Regressions

2 previously-covered lines in 2 files lost coverage.

File	Lines Losing Coverage	Coverage
Cpp2IL.Core/Model/Contexts/ConcreteGenericParameterAnalysisContext.cs	1	30.77%
Cpp2IL.Core/Model/Contexts/InjectedParameterAnalysisContext.cs	1	69.23%

---

Coverage Stats

Relevant Lines:	13144
Covered Lines:	5326
Line Coverage:	40.52%
Relevant Branches:	8656
Covered Branches:	2915
Branch Coverage:	33.68%
Branches in Coverage %:	Yes
Coverage Strength:	175459.83 hits per line

---

💛 - Coveralls

[SamboyCoding]

Not sure I actually like this concept. The correct thing to do here is to check the attributes to see if there is a literal or default value.

[ds5678]

Not sure I actually like this concept. The correct thing to do here is to check the attributes to see if there is a literal or default value.

Everywhere that the constant value is used, we also check the attributes.

[SamboyCoding]

Everywhere that the constant value is used, we also check the attributes.

this is my point. If we check the attributes, we KNOW whether it's a real null or no default value. This PR seems to be trying to solve something which is just user error.

[ds5678]

Everywhere that the constant value is used, we also check the attributes.

this is my point. If we check the attributes, we KNOW whether it's a real null or no default value.

No, we don't; LibCpp2IL returns null for errors, too.

Cpp2IL/LibCpp2IL/LibCpp2IlUtils.cs

Line 182 in 01c1748

if (pointer <= 0) return null;

Cpp2IL/LibCpp2IL/LibCpp2IlUtils.cs

Lines 229 to 230 in 01c1748

	default:
	return null;

This PR seems to be trying to solve something which is just user error.

The motivation for this PR was to enable Il2CppInterop to override parameter default values from 0/false to literal null (default(Struct)).

[SamboyCoding]

The motivation for this PR was to enable Il2CppInterop to override parameter default values from 0/false to literal null (default(Struct)).

This should be done by changing attributes. The error handling is exception case and should probably be changed to actually throw an exception.

[ds5678]

The motivation for this PR was to enable Il2CppInterop to override parameter default values from 0/false to literal null (default(Struct)).

This should be done by changing attributes.

I can't. Setting the object? override value to null does nothing because the default value is not null. The object? override is ambiguous between "no override" and "override to null".