Skip to content

Add PMP shorthand editing in Settings - #1352

Merged
7w1 merged 3 commits into
SableClient:devfrom
j0lol:shorthands-ui
Jul 27, 2026
Merged

Add PMP shorthand editing in Settings#1352
7w1 merged 3 commits into
SableClient:devfrom
j0lol:shorthands-ui

Conversation

@j0lol

@j0lol j0lol commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Description

  • Add PMP shorthand editing in Settings
  • Migrate from storing shorthands as regex in account data to { prefix?, suffix? }.
image

Part of #1279

Type of change

Note

This PR is a breaking change on an experimental feature, so I have considered it 'minor' instead of 'major'. Migrations have also been made so users should not expect issues.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@j0lol

j0lol commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

really struggling with making this todo list. i'm a fake react dev

Comment thread src/app/features/settings/Persona/PerMessageProfileEditor.tsx
Comment thread src/app/features/settings/Persona/PerMessageProfileEditor.tsx
@j0lol
j0lol force-pushed the shorthands-ui branch 3 times, most recently from 88c8ec8 to 420dd6a Compare July 25, 2026 20:07
@j0lol
j0lol marked this pull request as ready for review July 25, 2026 20:09
@j0lol
j0lol requested review from 7w1 and hazre as code owners July 25, 2026 20:09
@j0lol j0lol changed the title Shorthands UI Add PMP shorthand editing in Settings Jul 25, 2026
@j0lol
j0lol force-pushed the shorthands-ui branch 3 times, most recently from 438cd09 to 52051a6 Compare July 25, 2026 20:38
@j0lol

j0lol commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

Marking this draft quickly while i push through a bugfix for "Shorthand might not be used if a message contains a newline"

@j0lol
j0lol marked this pull request as draft July 25, 2026 20:50
@j0lol
j0lol force-pushed the shorthands-ui branch 2 times, most recently from 2156fb1 to d86373d Compare July 25, 2026 21:25
@j0lol

j0lol commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

fixed (proxy tags now use basic text functions instead of regex which has the potential to break on multiline. also added a test for it)

@j0lol
j0lol marked this pull request as ready for review July 25, 2026 21:26
@7w1
7w1 force-pushed the shorthands-ui branch from d86373d to 705ba8e Compare July 27, 2026 16:47
@7w1
7w1 added this pull request to the merge queue Jul 27, 2026
Merged via the queue into SableClient:dev with commit 0fa94c8 Jul 27, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants