Skip to content

IFDM-155: Fix to retirement calculator#103

Open
jenbreese wants to merge 1 commit into1.xfrom
IFDM-155--fixup
Open

IFDM-155: Fix to retirement calculator#103
jenbreese wants to merge 1 commit into1.xfrom
IFDM-155--fixup

Conversation

@jenbreese
Copy link
Copy Markdown
Collaborator

READY FOR REVIEW

Summary

  • Edits to the calculator

Review By (Date)

  • asap

Criticality

  • High

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to Retirement Calc
  3. Look at ticket for details
    4. Comment on ticket
  4. https://stanfordits.atlassian.net/browse/IFDM-155
  5. https://stanfordits.atlassian.net/browse/IFDM-155

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@jenbreese jenbreese requested a review from imonroe May 5, 2026 22:48
@jenbreese jenbreese self-assigned this May 5, 2026
@jenbreese jenbreese changed the title IFDM-155: Fix to calculator IFDM-155: Fix to retirement calculator May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant