Add optional label parameter for pkcs11 support#241
Merged
spoore1 merged 1 commit intoSSSD:masterfrom Apr 17, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an optional label parameter to the add_cert and add_key methods in the smartcard utility, allowing for PKCS#11 object labeling. Feedback was provided to update the docstrings for these methods to accurately reflect the str | None type hint for the new parameter to ensure consistency with the function signatures.
thalman
requested changes
Apr 15, 2026
Contributor
thalman
left a comment
thalman
left a comment
There was a problem hiding this comment.
I would say Gemini comments are valid, otherwise looks good.
krishnavema
force-pushed
the
smartcard-pkcs11
branch
from
524dbb8 to
2f83623
Compare
krishnavema
force-pushed
the
smartcard-pkcs11
branch
from
2f83623 to
2f139d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pkcs11 soft ocsp tests