Repository navigation
CI Fix - Turn on & fix ui-style and test-vscode CI stages #6004
Description
Activity
@nickmuoh -- want to tackle this one?
Picked this up — PR is open at #6054.
What surfaced once the two stages were back on:
prettier --check .fails on 4 files —.devcontainer/devcontainer.json,web/client/.../help.ts,web/client/.../ModelNode.tsx, and.github/workflows/pr.yamlitself (two matrix lists in it grew past 80 columns while the job was off).eslint src testsfails invscode/extension:tests/lineage_settings.spec.tsimportsFrameLocatorandPagestraight from@playwright/test, whichno-restricted-importsblocks for specs. Fixed by re-exportingFrameLocatorfromtests/fixtures.tsand importing from there, matching what every other spec does withPage.
With those fixed,
pnpm run lint(ui-style) andpnpm run ci(test-vscode) both exit 0 locally. Turned the jobs on following #5994, including thevscodepaths filter. Lefttest-vscode-e2ealone per your note.
Both
ui-styleandtest-vscodestages have been turned off. When I turned them back on there were failures onprettierformatting.First, we need to fix the formatting on the files.
Second, address any issues that bubble up in the stages to get them succeeding.
You can reference: #5994 for turning some of them on
NOTE:
test-vscode-e2ehas a note saying its been failing since January. This should be tackled separately in a different issue.