Skip to content

14231# Mumps clinical manifestation changes - #14267

Open
KarnaiahPesula wants to merge 2 commits into
developmentfrom
bugfix-mumps-symptom-form-changes
Open

14231# Mumps clinical manifestation changes#14267
KarnaiahPesula wants to merge 2 commits into
developmentfrom
bugfix-mumps-symptom-form-changes

Conversation

@KarnaiahPesula

@KarnaiahPesula KarnaiahPesula commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #

Summary by CodeRabbit

  • New Features

    • Added clearer clinical-manifestation headings and improved vertical organization of symptom labels.
    • Mumps-related symptoms are now displayed as dedicated labels for easier reporting.
  • Improvements

    • Dengue symptom reporting now adjusts clinical-manifestation visibility based on onset details.
    • Severity is automatically set when relevant symptoms are recorded.
    • Symptom values are displayed and cleared more consistently as selections change.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4102e48d-13d2-4573-bfe6-d78a01009209

📥 Commits

Reviewing files that changed from the base of the PR and between 33aaff5 and 6b31b20.

📒 Files selected for processing (1)
  • sormas-ui/src/main/java/de/symeda/sormas/ui/symptoms/SymptomsForm.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • sormas-ui/src/main/java/de/symeda/sormas/ui/symptoms/SymptomsForm.java

📝 Walkthrough

Walkthrough

ClinicalManifestation no longer contains Dengue or Mumps mappings. SymptomsForm now controls disease-specific clinical-manifestation visibility and renders selected Mumps symptoms as labels.

Changes

Symptom handling

Layer / File(s) Summary
Symptom UI structure
sormas-api/.../ClinicalManifestation.java, sormas-ui/.../SymptomsForm.java
Removed disease annotations from clinical manifestations. Added symptom constants, localization entries, and a dedicated clinical-manifestation label layout.
Disease-specific visibility handling
sormas-ui/.../SymptomsForm.java
Restricted severity and offset-date handling to Dengue. Mumps reporting symptoms now hide the selector and use the dedicated layout.
Rendered symptom labels
sormas-ui/.../SymptomsForm.java
Added label creation, update, and removal for affirmative and non-blank symptom values.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: roldy, raulbob

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only the unchanged template placeholder and does not identify the related issue or summarize the changes. Replace “Fixes #” with the issue number and add a concise summary of the Mumps symptom-form changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change to Mumps clinical manifestations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix-mumps-symptom-form-changes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@sormas-ui/src/main/java/de/symeda/sormas/ui/symptoms/SymptomsForm.java`:
- Around line 1636-1648: Update the symptom label handling around
symptomLabelMap so an existing non-blank text value updates the mapped Label
content instead of entering the removal branch. Keep the existing label and
refresh its value when the symptom changes between non-blank strings; only
remove the mapped component when the value becomes blank.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cb2d331f-a445-4259-8599-0165ffc7ed49

📥 Commits

Reviewing files that changed from the base of the PR and between e9a9dd3 and 33aaff5.

📒 Files selected for processing (2)
  • sormas-api/src/main/java/de/symeda/sormas/api/symptoms/ClinicalManifestation.java
  • sormas-ui/src/main/java/de/symeda/sormas/ui/symptoms/SymptomsForm.java
💤 Files with no reviewable changes (1)
  • sormas-api/src/main/java/de/symeda/sormas/api/symptoms/ClinicalManifestation.java

Comment thread sormas-ui/src/main/java/de/symeda/sormas/ui/symptoms/SymptomsForm.java Outdated
@KarnaiahPesula
KarnaiahPesula requested a review from raulbob August 6, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants