-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add resize, from_elem and wordvec! macro #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds WordVec::resize, WordVec::from_elem, and a new wordvec! macro; refactors trait impls and IntoIterator into dedicated modules; and reorganizes serde-related tests.
- Introduces WordVec::from_elem and WordVec::resize with tests for resize behavior.
- Extracts trait impls to src/trivial_traits.rs and IntoIterator to src/into_iter.rs.
- Adds wordvec! macro; moves serde tests out of tests.rs into src/serde_tests.rs under cfg(all(test, feature = "serde")).
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Adds from_elem and resize; refactors Large::extend_iter; small constructor helpers; module reorg. |
| src/macros.rs | Introduces wordvec! macro. |
| src/trivial_traits.rs | Centralizes trivial trait impls for WordVec. |
| src/into_iter.rs | Moves IntoIterator implementation for WordVec into its own module. |
| src/tests.rs | Adds resize tests; removes inlined serde tests. |
| src/serde_tests.rs | Rehomes serde tests under cfg(all(test, feature = "serde")). |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.