Skip to content

Conversation

@SOF3
Copy link
Owner

@SOF3 SOF3 commented Oct 16, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 16, 2025 15:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds WordVec::resize, WordVec::from_elem, and a new wordvec! macro; refactors trait impls and IntoIterator into dedicated modules; and reorganizes serde-related tests.

  • Introduces WordVec::from_elem and WordVec::resize with tests for resize behavior.
  • Extracts trait impls to src/trivial_traits.rs and IntoIterator to src/into_iter.rs.
  • Adds wordvec! macro; moves serde tests out of tests.rs into src/serde_tests.rs under cfg(all(test, feature = "serde")).

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/lib.rs Adds from_elem and resize; refactors Large::extend_iter; small constructor helpers; module reorg.
src/macros.rs Introduces wordvec! macro.
src/trivial_traits.rs Centralizes trivial trait impls for WordVec.
src/into_iter.rs Moves IntoIterator implementation for WordVec into its own module.
src/tests.rs Adds resize tests; removes inlined serde tests.
src/serde_tests.rs Rehomes serde tests under cfg(all(test, feature = "serde")).

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 19, 2025 06:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SOF3 SOF3 requested a review from Copilot October 19, 2025 07:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SOF3 SOF3 requested a review from Copilot October 19, 2025 07:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SOF3 SOF3 merged commit 66090a6 into master Oct 19, 2025
9 checks passed
@SOF3 SOF3 deleted the wordvec-macro branch October 19, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants