feat: update version to 2.2.3 and add getCachedValueOrLoad method for…#11
Open
TheBjoRedCraft wants to merge 2 commits into
Open
feat: update version to 2.2.3 and add getCachedValueOrLoad method for…#11TheBjoRedCraft wants to merge 2 commits into
TheBjoRedCraft wants to merge 2 commits into
Conversation
… offline player settings
There was a problem hiding this comment.
Pull request overview
This PR bumps the project version to 2.2.3 and extends the settings API with a new suspend method intended to retrieve settings for offline players, loading from persistence when the value is not already cached.
Changes:
- Bump Gradle project version from
2.2.2to2.2.3. - Add
SurfSettingsApi.getCachedValueOrLoad(...)to support retrieving settings for offline players. - Implement
getCachedValueOrLoad(...)in the Paper API implementation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
surf-settings-paper/src/main/kotlin/dev/slne/surf/settings/paper/api/SurfSettingsApiImpl.kt |
Implements the new offline-capable cached-or-load accessor (currently with a logic issue called out in a PR comment). |
surf-settings-api/src/main/kotlin/dev/slne/surf/settings/api/SurfSettingsApi.kt |
Adds the new suspend API method + KDoc describing offline behavior. |
gradle.properties |
Updates project version to 2.2.3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… offline player settings