Skip to content

feat: update version to 2.2.3 and add getCachedValueOrLoad method for…#11

Open
TheBjoRedCraft wants to merge 2 commits into
version/26.1from
feat/load-or-cached-api-exposed
Open

feat: update version to 2.2.3 and add getCachedValueOrLoad method for…#11
TheBjoRedCraft wants to merge 2 commits into
version/26.1from
feat/load-or-cached-api-exposed

Conversation

@TheBjoRedCraft
Copy link
Copy Markdown
Member

… offline player settings

@TheBjoRedCraft TheBjoRedCraft self-assigned this Jun 1, 2026
Copilot AI review requested due to automatic review settings June 1, 2026 13:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the project version to 2.2.3 and extends the settings API with a new suspend method intended to retrieve settings for offline players, loading from persistence when the value is not already cached.

Changes:

  • Bump Gradle project version from 2.2.2 to 2.2.3.
  • Add SurfSettingsApi.getCachedValueOrLoad(...) to support retrieving settings for offline players.
  • Implement getCachedValueOrLoad(...) in the Paper API implementation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
surf-settings-paper/src/main/kotlin/dev/slne/surf/settings/paper/api/SurfSettingsApiImpl.kt Implements the new offline-capable cached-or-load accessor (currently with a logic issue called out in a PR comment).
surf-settings-api/src/main/kotlin/dev/slne/surf/settings/api/SurfSettingsApi.kt Adds the new suspend API method + KDoc describing offline behavior.
gradle.properties Updates project version to 2.2.3.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants