Feat/disconnect message#359
Closed
TheBjoRedCraft wants to merge 4 commits into
Closed
Conversation
- implement buildDisconnectComponent function for customizable disconnect messages - support parameters for reason, details, issue footer, retry footer, and Discord link
Contributor
|
👋 TheBjoRedCraft your PR is conflicting and needs to be updated to be merged |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new helper in surf-api-core to build structured disconnect/kick-style messages via the SurfComponentBuilder DSL, and bumps the project version for release.
Changes:
- Added
CommonComponents.buildDisconnectComponent(...)for composing disconnect messages with configurable details and optional footers. - Switched
CommonComponents.ktadventure imports todev.slne.surf.api.core.messages.adventure.*. - Bumped
versionfrom3.13.0to3.13.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| surf-api-core/surf-api-core/src/main/kotlin/dev/slne/surf/api/core/messages/CommonComponents.kt | Introduces the new disconnect component builder helper and adjusts related imports. |
| gradle.properties | Increments the project version to 3.13.1. |
| appendNewline(2) | ||
| error(reason) | ||
| appendNewline(3) | ||
| append(details).color(SPACER) |
Comment on lines
+515
to
+526
| if (issue) { | ||
| append(ISSUE_FOOTER) | ||
| } | ||
|
|
||
| if (retryLater) { | ||
| append(RETRY_LATER_FOOTER) | ||
| } | ||
|
|
||
| if (onlyDiscordLink) { | ||
| appendNewline(2) | ||
| primary("discord.gg/castcrafter") | ||
| } |
Comment on lines
+506
to
+510
| appendNewline(2) | ||
| primary("CASTCRAFTER") | ||
| appendNewline() | ||
| primary("COMMUNITY SERVER") | ||
| appendNewline(2) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
This PR contains changes that modified the public API. To update the reference ABI dumps: ./gradlew updateKotlinAbi
git add **/api/**
git commit -m "Update ABI reference"
git pushAfter updating, the CI will pass. Make sure the changes are backward compatible. |
1 similar comment
Contributor
|
This PR contains changes that modified the public API. To update the reference ABI dumps: ./gradlew updateKotlinAbi
git add **/api/**
git commit -m "Update ABI reference"
git pushAfter updating, the CI will pass. Make sure the changes are backward compatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.