Skip to content

RCBPtn read/write fix - #49

Merged
cwsmith merged 4 commits into
SCOREC:mainfrom
hgangwar:fix_rcb_ptn
Oct 31, 2025
Merged

RCBPtn read/write fix#49
cwsmith merged 4 commits into
SCOREC:mainfrom
hgangwar:fix_rcb_ptn

Conversation

@hgangwar

@hgangwar hgangwar commented Oct 4, 2025

Copy link
Copy Markdown
Contributor
  • Adds the $\text{dimVar}$ in $\text{RCBPtn}$ read/write functions.
  • Fixes the $\text{cutsVar}$ scheduling.

@cwsmith

cwsmith commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

@hgangwar Would you mind pushing another very simple commit (i.e., add a non-offensive empty line somewhere in redev.cpp) so that our CI triggers again? This is the first commit to this repo in a very long time and github automatically disabled the build+test workflow. Nevermind. There is something wrong with that workflow (see https://github.com/SCOREC/redev/actions/runs/18237925126/job/51934949032).

@hgangwar

hgangwar commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

run: /usr/bin/cmake $GITHUB_WORKSPACE/redev
-DCMAKE_CXX_COMPILER=mpicxx
-DCMAKE_CC_COMPILER=mpicc
-DCMAKE_BUILD_TYPE=${{matrix.build_type}}
-DADIOS2_DIR=${{runner.workspace}}/build-adios2/install/lib/cmake/adios2/
-DADIOS2_HAVE_SST=ON
-DADIOS2_BPLS_PATH=${{runner.workspace}}/build-adios2/install/bin/bpls
-DBUILD_TESTING=ON

The workflow is not up to date with the current CMakeLists.txt. Perfstubs was introduced later and is now a required package.

@cwsmith

cwsmith commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

adios2 vendors perfstubs ... even in the ancient version 2.9 that we are using. An issue for the CI problem is here: #50

@cwsmith

cwsmith commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

@hgangwar Would you please merge or rebase on main? There are changes there to the CI that should fix the adios/perfstubs issues with the latest failing CI builds.

@jacobmerson

Copy link
Copy Markdown
Collaborator

@cwsmith looks like this is all set to merge.

@cwsmith
cwsmith merged commit ff25510 into SCOREC:main Oct 31, 2025
5 checks passed
@hgangwar
hgangwar deleted the fix_rcb_ptn branch November 11, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants