Added multi admin support for event creation and editing#2114
Open
maernest04 wants to merge 3 commits intodevfrom
Open
Added multi admin support for event creation and editing#2114maernest04 wants to merge 3 commits intodevfrom
maernest04 wants to merge 3 commits intodevfrom
Conversation
- Added ability to add and remove admins from access to editing an event - Added admin search to search through all available admins - Added endpoints to check admin IDs - Added warnings when adding or removing admins, including removing themselves
steeevin88
requested changes
Apr 29, 2026
Collaborator
steeevin88
left a comment
There was a problem hiding this comment.
- can you add some screenshots to show what the UI looks like?
- CI is failing, let's fix this
- from my (albeit brief) understanding, this code only allows us to add Clark admins as event admins, but realistically, we should allow... any person? how much more complicated would this be, i know admins is already a lot of code 😅 thought this would be a simpler change apologies
- Changed route to allow any authenticated user to edit avents - User search and admin validation now support any user like non officer users (members or non members) - Removed site wide admin / officer role checks for the event management UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #2113
Problem
For SCEvents, event creation allowed admins to create and edit their own events but there was no way for other admins to be able to edit events they didn't create. There should be a way for the event's original creator to add and remove admins who can edit their event.
Solution
Added a multi-admin picker UI to both the Create Event and Edit Event pages. Admins can search for other admins by name or email and add/remove them from the event. A new backend endpoint
POST /api/User/admins/validateresolves stored admin IDs into user objects so the edit page can display names and emails instead of raw IDs.Files Changed
src/Pages/Events/CreateEventPage.jssrc/Pages/Events/EditEventPage.jssrc/APIFunctions/User.jsvalidateEventAdminsfrontend API functionapi/main_endpoints/routes/User.jsPOST /admins/validateendpointtest/api/User.js/admins/validateScreenshots
Event Admin section of event creation and editing
Searching for any person to add as an editor (admin, member, any level of membership)
Warning when attempting to remove every event admin, including themselves
Warning when attempting to save changes after removing themselves as event admin