feat: extensibility ums destination changes - #260
Conversation
| ENV_CONHOS_LANDSCAPE = "APPFND_CONHOS_LANDSCAPE" | ||
| ENV_UMS_DESTINATION_NAME = "APPFND_UMS_DESTINATION_NAME" | ||
| ENV_UMS_URL = "APPFND_CONHOS_UMS_URL" | ||
| _UMS_DESTINATION_PREFIX = "sap-managed-runtime-ums-" |
There was a problem hiding this comment.
I believe we can remove the ums destination since this was never provisioned on managed runtime
There was a problem hiding this comment.
Better to not keep the two ways so code is more readable
There was a problem hiding this comment.
There are some existing agents that are referring to this destination, which are manually created
There was a problem hiding this comment.
Ok, but the new approach should work for all agents since it's automated, no need to keep this work-around on sdk. And if the new approach is not there, they don't need to adopt the new version right now.
There was a problem hiding this comment.
Modified the code as suggested
|
How have you validated these changes? On which agent? |
We have an agent https://github.tools.sap/agent-extensibility-test/extensibility-tools-agent; I have started this agent locally and applied the SDK changes to this agent |
Description
UMS Destination - New connectivity model
This change is needed because the AppFND team suggested using an existing destination name (sap-managed-runtime-ias-${landscape}) instead of creating a new destination name (sap-managed-runtime-ums-${landscape}) to read the extensions.
Hence, the current code needs to be modified to use the one the AppFND team suggested.
Environment variable support:
Added APPFND_CONHOS_UMS_URL to enable the new IAS-based flow
Dynamic destination resolution:
When APPFND_CONHOS_UMS_URL is set → uses IAS destination (sap-managed-runtime-ias-{landscape})
Otherwise → falls back to legacy UMS destination (sap-managed-runtime-ums-{landscape})
URL resolution logic:
New flow: Base URL from APPFND_CONHOS_UMS_URL environment variable
Legacy flow: Base URL from destination configuration
Both flows: mTLS certificate always from the resolved destination
Related Issue
NA
(Link to the GitHub issue this PR addresses)
Type of Change
Please check the relevant option:
How to Test
Describe how reviewers can test your changes:
Checklist
Before submitting your PR, please review and check the following:
Breaking Changes
There are no breaking changes. We have BCT (Backwards Compatibility) enabled; if the env variable is not found, then it will go with old behaviour
Additional Notes
Tested in the local agent and it worked.