feat(agw): add correlation_id and request path to agw error outputs - #258
Open
ricardosrib wants to merge 1 commit into
Open
feat(agw): add correlation_id and request path to agw error outputs#258ricardosrib wants to merge 1 commit into
ricardosrib wants to merge 1 commit into
Conversation
ricardosrib
changed the title
NicoleMGomes
reviewed
Aug 5, 2026
| Raises: | ||
| AgentGatewaySDKError: If server does not provide serverInfo.name. | ||
| """ | ||
| logger.debug( |
Contributor
There was a problem hiding this comment.
Correlation id is already part of traces with attribute trace id. We can enhance logs and errors messages, but let's not use correlation id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Every AGW call (MCP list, MCP call, A2A card fetch) now generates a correlation ID that is sent as x-correlation-id and included in all error log lines and exception messages alongside the request path. This gives LoB developers a single identifier for log lookup without needing raw traces.
Related Issue
Closes #195 , #247
Type of Change
Please check the relevant option:
How to Test
Enable
DEBUGlogging and calllist_mcp_toolsorcall_mcp_tool— verify log lines include[correlation-id=<uuid>, path=<url>]before each AGW request.Trigger a failure (unreachable host or invalid token) — verify the
ERRORlog line and any raisedAgentGatewaySDKErrormessage contain the same[correlation-id=<uuid>, path=<url>]as the preceding DEBUG line.Checklist
Before submitting your PR, please review and check the following:
Breaking Changes
N/A
Additional Notes
N/A