fix: return empty list instead of raising error when integrationDepen… - #235
Merged
Conversation
Contributor
|
Please verify failing checks and fulfill PR template (we have a command on claude to facilitate it |
Older MCP versions yield (read, write), newer versions yield (read, write, get_session_id). Use *_ to unpack safely across both.
…sError in tool results - Use *_ to unpack streamable_http_client tuples for MCP 2-tuple/3-tuple compat - Add _log_mcp_server_error helper that unwraps BaseExceptionGroup to surface the actual HTTP status code and response body from gateway errors - Log result.isError=true tool responses at ERROR level instead of silently returning
NicoleMGomes
previously approved these changes
Aug 2, 2026
cassiofariasmachado
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
get_mcp_tools_customerto return an empty list instead of raisingAgentGatewaySDKErrorwhenintegrationDependenciesis empty in the credentials. An empty dependency list is a valid configuration (no MCP servers to connect to), so raising an error was unnecessarily strict. A warning is logged instead to surface the misconfiguration to the user.Related Issue
N/A
Type of Change
How to Test
CustomerCredentialswithintegration_dependencies=[]get_mcp_tools_customer(credentials, token, timeout)[]without raising an error; a warning is loggedChecklist
Breaking Changes
None — previously this raised an error, so callers that previously needed a try/except can simplify, but no existing working code breaks.