Skip to content

Conversation

@KavithaSiva
Copy link
Contributor

@KavithaSiva KavithaSiva commented Nov 26, 2025

Context

This PR adapts the current RAG example using the latest RAG agent tutorial.

It also fixes smoke-test failures by adding the missing @langchain/classic package.

Successful test run: https://github.com/SAP/ai-sdk-js/actions/runs/19854088195

@KavithaSiva KavithaSiva marked this pull request as ready for review November 26, 2025 09:53
@ZhongpinWang
Copy link
Contributor

Perhaps we can adapt this RAG example and avoid using the more or less legacy usages. https://www.npmjs.com/package/@langchain/classic

@KavithaSiva KavithaSiva changed the title fix: Add missing langchain dependency in smoke test fix: Add failing smoke test Dec 1, 2025
@KavithaSiva KavithaSiva changed the title fix: Add failing smoke test fix: Failing smoke test Dec 1, 2025
@KavithaSiva
Copy link
Contributor Author

Perhaps we can adapt this RAG example and avoid using the more or less legacy usages. https://www.npmjs.com/package/@langchain/classic

I have adapted the RAG sample to use createAgent based on the new RAG agent tutorial, so, I did manage to remove few imports from the classic package.

But some imports like MemoryVectorStore and TextLoader still require the langchain classic package.

@KavithaSiva KavithaSiva changed the title fix: Failing smoke test fix: Adapt RAG example to use createAgent Dec 2, 2025
@KavithaSiva KavithaSiva merged commit 6964f13 into main Dec 8, 2025
13 checks passed
@KavithaSiva KavithaSiva deleted the fix/smoke-test-app branch December 8, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants