Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We got notified that our Java spec update workflow erroneously failed on two different PRs of the orchestration team. Both branches changed the spec, but in very little ways (only explanation text changed).
It turned out that our spec update workflow succeeded on the first pushes (including the spec changes) but failed whenever there was a push to the PR branches that did not change the spec again. What happened is the following:
main, not the feature branch created in the first workflow run. This is intentional (and was changed rather recently, PR here) but results in the workflow finding spec changes even though there were no new spec changes.spec-update/orchestration/xyz, notmain. This is also correct since we do not want to push tomain. But at this point there are no changes to push. So thegit pushfails with the messagenothing to commit, working tree cleanand the workflow fails.This PR introduces a check to the Push changes step to check if there are actual changes to push to the feature branch
spec-update/orchestration/xyz. If not, the step does not push but finishes successfully.