feat: Introduce TcpClientFactory

[seilc1]

Allows injecting custom TcpClient for monitoring and logging

[gfoidl]

custom TcpClient for monitoring and logging

Seems reasonable to me.

---

A different approach -- more or less a quite big rewrite -- would be incorporate logging, tracing, and metrics into the lib. But that's a lot of work, and older target frameworks won't profit from that change. So your approach seems to be the better way here.

[seilc1]

custom TcpClient for monitoring and logging

Seems reasonable to me.

A different approach -- more or less a quite big rewrite -- would be incorporate logging, tracing, and metrics into the lib. But that's a lot of work, and older target frameworks won't profit from that change. So your approach seems to be the better way here.

Besides being a bigger rewrite it's also a question of what's needed. I'm not sure if "my" need for logging/metrics would fit a general need or implementation style. So I think it's better to just provide the "possibility".

[gfoidl]

LGTM -- modulo one comment.

I'd like to hear what the others think about this.

[gfoidl]

Please don't force push a branch when a PR is open, that makes reviewing harder, as the last diff disappears.
Just push the normal commit to the branch.

When merging the PR, then (IMO ideally) a squash-merge is done to get the linear history in the main-branch again.

[seilc1]

@gfoidl : any idea when your peers will react?

[mycroes]

@gfoidl : any idea when your peers will react?

Sorry for my late response, awfully busy lately... This seems to be fine, I need to fix the workflows though so GH can also verify it builds. I'll try to get this fixed ASAP.

[seilc1]

@gfoidl : any idea when your peers will react?

Sorry for my late response, awfully busy lately... This seems to be fine, I need to fix the workflows though so GH can also verify it builds. I'll try to get this fixed ASAP.

Can I support somhow?

[mycroes]

@gfoidl : any idea when your peers will react?

Sorry for my late response, awfully busy lately... This seems to be fine, I need to fix the workflows though so GH can also verify it builds. I'll try to get this fixed ASAP.

Can I support somhow?

See PR #557. Unfortunately the unit tests don't run reliably, I'm not 100% sure of the cause, but it might be that the tests execute concurrently thus causing the failures. Feel free to chime in.