ctutils: import Choice methods from crypto-bigint
#1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
added a commit
to RustCrypto/crypto-bigint
that referenced
this pull request
Dec 20, 2025
Depends on RustCrypto/utils#1266 Extracts all of the `const fn` constructor and predication/selection methods used by `crypto-bigint` into the `ctutils` crate, allowing the `ConstChoice` type to be removed and replaced by `ctutils::Choice`.
tarcieri
force-pushed
the
ctutils/crypto-bigint-methods
branch
from
09cce25 to
5d2fc4d
Compare
tarcieri
added a commit
to RustCrypto/crypto-bigint
that referenced
this pull request
Dec 20, 2025
Depends on RustCrypto/utils#1266 Extracts all of the `const fn` constructor and predication/selection methods used by `crypto-bigint` into the `ctutils` crate, allowing the `ConstChoice` type to be removed and replaced by `ctutils::Choice`.
tarcieri
force-pushed
the
ctutils/crypto-bigint-methods
branch
from
5d2fc4d to
4f732b7
Compare
tarcieri
added a commit
to RustCrypto/crypto-bigint
that referenced
this pull request
Dec 20, 2025
Depends on RustCrypto/utils#1266 Extracts all of the `const fn` constructor and predication/selection methods used by `crypto-bigint` into the `ctutils` crate, allowing the `ConstChoice` type to be removed and replaced by `ctutils::Choice`.
tarcieri
added a commit
to RustCrypto/crypto-bigint
that referenced
this pull request
Dec 20, 2025
Depends on RustCrypto/utils#1266 Extracts all of the `const fn` constructor and predication/selection methods used by `crypto-bigint` into the `ctutils` crate, allowing the `ConstChoice` type to be removed and replaced by `ctutils::Choice`.
tarcieri
added a commit
to RustCrypto/crypto-bigint
that referenced
this pull request
Dec 20, 2025
Depends on RustCrypto/utils#1266 Extracts all of the `const fn` constructor and predication/selection methods used by `crypto-bigint` into the `ctutils` crate, allowing the `ConstChoice` type to be removed and replaced by `ctutils::Choice`.
tarcieri
added a commit
to RustCrypto/crypto-bigint
that referenced
this pull request
Dec 20, 2025
Depends on RustCrypto/utils#1266 Extracts all of the `const fn` constructor and predication/selection methods used by `crypto-bigint` into the `ctutils` crate, allowing the `ConstChoice` type to be removed and replaced by `ctutils::Choice`.
tarcieri
force-pushed
the
ctutils/crypto-bigint-methods
branch
from
4f732b7 to
5101c8c
Compare
tarcieri
changed the title
Choice methods from crypto-bigintChoice methods from crypto-bigint
tarcieri
force-pushed
the
ctutils/crypto-bigint-methods
branch
3 times, most recently
from
e3b5746 to
325e764
Compare
tarcieri
added a commit
to RustCrypto/crypto-bigint
that referenced
this pull request
Dec 20, 2025
Depends on RustCrypto/utils#1266 Extracts all of the `const fn` constructor and predication/selection methods used by `crypto-bigint` into the `ctutils` crate, allowing the `ConstChoice` type to be removed and replaced by `ctutils::Choice`.
This imports all of the `const fn` constructor and predication/selection methods `crypto-bigint` needs to replace `crypto_bigint::ConstChoice` with `ctutils::Choice`, along with extant tests, and adds additional tests for better coverage.
tarcieri
force-pushed
the
ctutils/crypto-bigint-methods
branch
from
325e764 to
295486a
Compare
tarcieri
added a commit
to RustCrypto/crypto-bigint
that referenced
this pull request
Dec 20, 2025
Depends on RustCrypto/utils#1266 Extracts all of the `const fn` constructor and predication/selection methods used by `crypto-bigint` into the `ctutils` crate, allowing the `ConstChoice` type to be removed and replaced by `ctutils::Choice`.
tarcieri
added a commit
to RustCrypto/crypto-bigint
that referenced
this pull request
Dec 24, 2025
Extracts all of the `const fn` constructor and predication/selection methods used by `crypto-bigint` into the `ctutils` crate, allowing the `ConstChoice` type to be removed and replaced by `ctutils::Choice`. See RustCrypto/utils#1266 for the PR which adds these methods to `ctutils`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports all of the
const fnconstructor and predication/selection methodscrypto-bigintneeds to replacecrypto_bigint::ConstChoicewithctutils::Choice, along with extant tests.