fix: add missing hasher2.reset() before chunks loop in dev tests#2310
Closed
radik878 wants to merge 3 commits intoRustCrypto:masterfrom
Closed
fix: add missing hasher2.reset() before chunks loop in dev tests#2310radik878 wants to merge 3 commits intoRustCrypto:masterfrom
radik878 wants to merge 3 commits intoRustCrypto:masterfrom
Conversation
Member
|
The state is reset by finalize_reset functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test functions fixed_reset_test, variable_reset_test, and xof_reset_test were not resetting hasher2 before the chunks loop, causing state accumulation across different chunk size iterations.