fix(slh-dsa): use checked_shl for idx_tree range in tests#1224
Open
sashass1315 wants to merge 2 commits intoRustCrypto:masterfrom
Open
fix(slh-dsa): use checked_shl for idx_tree range in tests#1224sashass1315 wants to merge 2 commits intoRustCrypto:masterfrom
sashass1315 wants to merge 2 commits intoRustCrypto:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrapping_shl(64)on u64 wraps the shift amount modulo 64, producing1 << 0 = 1instead of the intended0. This causedidx_treerange to collapse to0..=0for 256f parameter sets (where H - H' = 64), meaning those tests always ran withidx_tree = 0.Replace
wrapping_shlwithchecked_shl(...).unwrap_or(0)to match the pattern already used in production code [split_digest]signatures/slh-dsa/src/util.rs
Lines 26 to 50 in b54e7ba
Affects hypertree and FORS test functions (4 call sites).