fix(ecdsa): correct error message for invalid vector.k in dev macro#1220
Open
GarmashAlex wants to merge 1 commit intoRustCrypto:masterfrom
Open
fix(ecdsa): correct error message for invalid vector.k in dev macro#1220GarmashAlex wants to merge 1 commit intoRustCrypto:masterfrom
GarmashAlex wants to merge 1 commit intoRustCrypto:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause: The error message in the
new_signing_testmacro incorrectly referred to "vector.m" when checking the ephemeral scalark, which was a copy-paste error from the line below. This would confuse developers debugging test failures since the message doesn't match the actual field.Changes: Fixed the error message in
decode_scalar(vector.k).expect()to correctly reference "invalid vector.k" instead of "invalid vector.m".