Skip to content

der: remove deprecated SetOf(Vec)::add methods #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Feb 13, 2026
+0 −23
Merged

der: remove deprecated SetOf(Vec)::add methods #2232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions der/src/asn1/set_of.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,6 @@ where
}
}

/// Add an item to this [`SetOf`].
///
/// Items MUST be added in lexicographical order according to the [`DerOrd`] impl on `T`.
///
/// # Errors
/// If items are added out-of-order or there isn't sufficient space.
#[deprecated(since = "0.7.6", note = "use `insert` or `insert_ordered` instead")]
pub fn add(&mut self, new_elem: T) -> Result<(), Error> {
self.insert_ordered(new_elem)
}

/// Insert an item into this [`SetOf`].
///
/// # Errors
Expand Down Expand Up @@ -297,18 +286,6 @@ where
Vec::from_iter(iter).try_into()
}

/// Add an element to this [`SetOfVec`].
///
/// Items MUST be added in lexicographical order according to the
/// [`DerOrd`] impl on `T`.
///
/// # Errors
/// If a sorting error occurred.
#[deprecated(since = "0.7.6", note = "use `insert` or `insert_ordered` instead")]
pub fn add(&mut self, item: T) -> Result<(), Error> {
self.insert_ordered(item)
}

/// Extend a [`SetOfVec`] using an iterator.
///
/// Note: this is an inherent method instead of an impl of the [`Extend`] trait in order to
Expand Down