doc: clarify xgcd_vartime delegates to constant-time xgcd (pending #853) - #1333
Open
LuisCastellanos-dev wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1333 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 189 189
Lines 22654 22654
=======================================
Hits 20630 20630
Misses 2024 2024 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xgcd_vartimeforUint,NonZeroUintandOddUintcurrently callsxgcd(CT)due to #853. This is not documented, so callers expecting VT performance get CT
silently, and will silently change from CT to VT when #853 is implemented.
This adds an explicit NOTE explaining the current delegation and warning about
the future semantics change.
No code or logic change — documentation only.
No functional change in release build.