Fix Default impl for Odd
#1071
Merged
Fix Default impl for Odd
#1071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously derived, which would use the `Default` impl of the underlying `T` which, in almost every case, will return zero, violating the invariant of the type. This adds a custom `Default` impl similar to the one on `NonZero` which is bounded on `One` trait, and returns `Odd(T::one())`. Fixes #1070
tarcieri
commented
Jan 4, 2026
| impl<T> Default for NonZero<T> | ||
| where | ||
| T: Constants, | ||
| T: One, |
Member
Author
There was a problem hiding this comment.
Went ahead and relaxed this bound considerably too
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1071 +/- ##
==========================================
+ Coverage 78.83% 78.86% +0.02%
==========================================
Files 173 173
Lines 17716 17725 +9
==========================================
+ Hits 13966 13978 +12
+ Misses 3750 3747 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously derived, which would use the
Defaultimpl of the underlyingTwhich, in almost every case, will return zero, violating the invariant of the type.This adds a custom
Defaultimpl similar to the one onNonZerowhich is bounded onOnetrait, and returnsOdd(T::one()).Fixes #1070