Skip to content

refactor: remove redundant heap allocation in OAEP decrypt_inner #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Feb 11, 2026
Merged

refactor: remove redundant heap allocation in OAEP decrypt_inner #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/algorithms/oaep.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,9 @@ where
return Err(Error::Decryption);
}

let (out, index) = res.unwrap();
let index = res.unwrap();

Ok(out[index as usize..].to_vec())
Ok(em[index as usize..].to_vec())
}

///Decrypts OAEP padding.
Expand Down Expand Up @@ -205,9 +205,9 @@ where
return Err(Error::Decryption);
}

let (out, index) = res.unwrap();
let index = res.unwrap();

Ok(out[index as usize..].to_vec())
Ok(em[index as usize..].to_vec())
}

/// Decrypts OAEP padding. It returns one or zero in valid that indicates whether the
Expand All @@ -219,7 +219,7 @@ fn decrypt_inner<MGF: FnMut(&mut [u8], &mut [u8])>(
expected_p_hash: &[u8],
k: usize,
mut mgf: MGF,
) -> Result<CtOption<(Vec<u8>, u32)>> {
) -> Result<CtOption<u32>> {
if k < 11 {
return Err(Error::Decryption);
}
Expand Down Expand Up @@ -256,8 +256,5 @@ fn decrypt_inner<MGF: FnMut(&mut [u8], &mut [u8])>(

let valid = first_byte_is_zero & hash_are_equal & !nonzero_before_one & !looking_for_index;

Ok(CtOption::new(
(em.to_vec(), index + 2 + (h_size * 2) as u32),
valid,
))
Ok(CtOption::new(index + 2 + (h_size * 2) as u32, valid))
}