fix: add missing check_public validation in OAEP decrypt#656
Closed
sashass1315 wants to merge 1 commit intoRustCrypto:masterfrom
Closed
fix: add missing check_public validation in OAEP decrypt#656sashass1315 wants to merge 1 commit intoRustCrypto:masterfrom
sashass1315 wants to merge 1 commit intoRustCrypto:masterfrom
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The oaep::decrypt function (used by the PaddingScheme trait impl for Oaep) was missing a check_public() call, unlike every other encrypt/decrypt function in the codebase:
This meant that when using the Oaep padding scheme directly via RsaPrivateKey::decrypt(), the public key components were not validated, breaking the defense-in-depth pattern used throughout the library.
The fix adds the missing check_public() call at the top of oaep::decrypt, consistent with all sibling functions.
A regression test (behind the hazmat feature) is included that constructs a key with an oversized public exponent and verifies that
both OAEP decrypt paths (PaddingScheme and DecryptingKey) correctly reject it.