Open
Conversation
Author
|
Actually, it is more complicated than that, please don't merge now. The Signal article does not explicit the algorithms, so I will have to dig libcrux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #264
Implemented incremental ML-KEM and corresponding tests.
I used function names like
encapsulate_incremental_1so people who want to use the standard interface won't be confused by ambiguousencapsulate_1. The types used should also prevent some erroneous uses like mixing interfaces.I'm not sure about the name
EncapsulationSecretbecause it's a bit ambiguous (it may be misunderstood as the shared secret).