Repository navigation
fix(wasapi): initialize notification threads as MTA - #1413
dannyward630 wants to merge 6 commits into
Conversation
#1411 will fix this, so no concern there.
As for the diff, anything COM related is more @LastExceed's territory, so I haven't really checked it over. I believe there was already a lot of discussion of this/similar in #1302 |
|
The whole situation is a mess, there really shouldn't be an STA requirement for WASAPI in the first place. I also find the current WASAPI code to be rather ugly in general, and this PR doesn't exactly improve the situation. What we really need is a full rewrite of the WASAPI host, based on WinRT to get rid of all the COM headaches in general, and using the |
Having something more robust: sure, why not, but like you said, it might take time. Second, I'm always careful to long for greener pastures. Legacy code has typically accumulated so many fixes and edge cases, that sometimes it's easier to refactor in place than to rewrite entirely.
In the meantime I think we should definitely continue to consider fixes and refactoring. I'm just not sure if this is it though. At first glance, I'm seeing some correctness and idiomatic issues. |
Closes #1402
Summary
AI assistance: Codex contributed implementation and tests.
Validation
cargo fmt --all -- --check— passed.cargo check --tests --target x86_64-pc-windows-gnu— passed; this cross-compiled the Windows library and test code but did not execute the tests.cargo clippy --lib --target x86_64-pc-windows-gnu -- -A dead_code— passed; the allowance is for the existing unrelatedframes_to_durationwarning.git diff --check— passed.c806859passed across Code Quality, platform compatibility, and sanitizer workflows.