fix(jack): cap channel enumeration at physical port count again - #1314
Merged
Conversation
0.18.2 uncapped enumeration alongside allowing streams to be built with more channels than physical ports, so supported_*_configs now reports up to 64 channels on every device. Re-cap enumeration only; stream creation still allows more channels than that for patching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.18.2 uncapped enumeration alongside allowing streams to be built with more channels than physical ports, so
supported_*_configsnow reports up to 64 channels on every device. Stream creation still allows more channels than that for patching.When rethinking the entire
StreamConfigAPI, I'm thinking to discern what's supported (what could be routed or mixed) and what's preferred (what the output device supports, typically). This is for later in 0.19; suggestions welcome.