feat(realtime): rename feature, make default, and report RT denials#1187
Open
roderickvd wants to merge 16 commits intomasterfrom
Open
feat(realtime): rename feature, make default, and report RT denials#1187roderickvd wants to merge 16 commits intomasterfrom
roderickvd wants to merge 16 commits intomasterfrom
Conversation
- Rename the `audio_thread_priority` feature to `realtime` and make it default. - Gate AAudio PERFORMANCE_MODE_LOW_LATENCY and PipeWire RT_PROCESS. - Rename ErrorKind::RealtimeUnavailable to RealtimeDenied. - Add RealtimeDenied error reporting to AAudio, PipeWire and JACK. - Fix AAudio error_callback not being forwarded to the caller.
roderickvd
force-pushed
the
feat/update-thread-priority
branch
from
51b53ff to
603251b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
src/host/pipewire/stream.rs:420
- This metadata listener is registered with
add_listener_local, so it runs on PipeWire's mainloop thread.emit_error_or_warncan still invoke the user callback here, and if the application drops the stream from that callbackStream::dropwill try to join the current thread and deadlock.
&error_callback_cb,
Error::with_message(
ErrorKind::DeviceChanged,
"default device changed",
),
);
} else if !invalidated_cb.swap(true, Ordering::Relaxed) {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audio_thread_priorityfeature torealtime-dbusand make it default.PERFORMANCE_MODE_LOW_LATENCYand PipeWireRT_PROCESS.ErrorKind::RealtimeUnavailabletoRealtimeDenied.error_callbacknot being forwarded to the caller.