fix(aaudio): Wait for AAudioStream status change#1125
Open
osoftware wants to merge 1 commit intoRustAudio:masterfrom
Open
fix(aaudio): Wait for AAudioStream status change#1125osoftware wants to merge 1 commit intoRustAudio:masterfrom
osoftware wants to merge 1 commit intoRustAudio:masterfrom
Conversation
roderickvd
reviewed
Mar 16, 2026
src/host/aaudio/mod.rs
Outdated
|
|
||
| stream.request_start().map_err(PlayStreamError::from)?; | ||
| stream | ||
| .wait_for_state_change(ndk::audio::AudioStreamState::Starting, 300_000_000) |
Member
There was a problem hiding this comment.
Not an expert in AAudio but isn't Oboe's kDefaultTimeoutNanos equal to 2_000_000_000? Would that be worth using and documenting? If there is a reason why 300_000_000 would be more appropriate, that magic number would also be deserving of a comment.
Author
There was a problem hiding this comment.
I wasn't aware of this const, I'll try it out.
| } | ||
|
|
||
| impl StreamTrait for Stream { | ||
| fn play(&self) -> Result<(), PlayStreamError> { |
Member
There was a problem hiding this comment.
Wouldn't same also apply to pause()?
Author
There was a problem hiding this comment.
I might makes sense to use wait_for_state_change consistently in both but not using it on pause doesn't yield any serious issues and the method returns faster which might be preferable. IDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs at once.
After starting the stream and before the status changes to
Started, dropping it causes the main thread to lock permanently. The underlyingAAudioStreamnever closes while thedropmethod waits for it to close. By usingwait_for_state_changemethod we ensure theplaymethod won't return befor it's safe to drop the stream.If
wait_for_state_changeis never called thenAAudioStream_getTimestampalways returnsInvalidStateerror leading toinfo.timestamp().captureandinfo.timestamp().playbackin stream callbacks always returning zero.