Repository navigation
set alignment of i128 to 16 - #672
Conversation
5ae3151 to
b8af955
Compare
Can someone educate me what is the benefit of this? Sorry if this is the wrong place to ask,but I've seen this backwards compatibility surfacing a few times and I'm not sure why it is important if the toolchain is fixed and is generally kept in sync with the rest of rust-gpu stack. |
|
TLDR: So your locally installed There's the dependency chain of |
|
I see, so this is just for CLI. I'm now wondering if it would be possible to move this target logic elsewhere, so CLI is a thin wrapper instead. For example, by compiling not just SPIR-V backend shared library, but also some kind of "real" binary that Not that it matters to me personally, but I think that might survive backward and forward compatibility a bit better. |
|
We've had that if you go waaay back towards the first cargo-gpu versions schell made... and it was very annoying to maintain. Imagine it as a copy of the current spirv-builder you'd configure and serialize to send that json to another spirv-builder compiled by rust-gpu's rustc version that deserializes it and passes it onto the real spirv-builder. Now we just have one spirv-builder. |
|
I'd just expect a thin wrapper that builds "real" |
As we need to change the target specs, and target specs are dependent on rustc version to provide backwards compatability with older rustc_codegen_spirv versions, we can only really change target specs when we update rustc. So we've got the choice of:
See https://llvm.org/docs/LangRef.html#data-layout for how to specify data layouts.
close #665