fix(cudnn): remove duplicate ConvBwdData match arm in backend graph builder#372
Open
CharryWu wants to merge 1 commit intoRust-GPU:mainfrom
Open
fix(cudnn): remove duplicate ConvBwdData match arm in backend graph builder#372CharryWu wants to merge 1 commit intoRust-GPU:mainfrom
CharryWu wants to merge 1 commit intoRust-GPU:mainfrom
Conversation
…uilder The operations iterator map in GraphBuilder::build() had two identical Operation::ConvBwdData arms. The second arm was unreachable dead code. Removed the duplicate; all seven operation variants are now matched once. Made-with: Cursor
frjnn
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a duplicate unreachable match arm in the cuDNN backend graph builder.
Problem
In GraphBuilder::build(), the operations iterator map had two identical arms for Operation::ConvBwdData. The second arm was unreachable dead code and would generate a compiler warning under strict linting.
Change
Remove the duplicate arm. All seven operation variants (ConvBwdData, ConvBwdFilter, ConvFwd, MatMul, Pointwise, Reduction) are now each matched exactly once.
Testing