NvvmArch cleanups
#304
Merged
NvvmArch cleanups
#304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
force-pushed
the
NvvmArch-cleanups
branch
from
db485c2 to
cc450b2
Compare
LegNeato
approved these changes
Nov 18, 2025
Collaborator
Author
|
This will conflict with #306. That PR is more important so I will wait for it to merge first. I might also add some extra stuff here. Hence the "draft" status. |
nnethercote
force-pushed
the
NvvmArch-cleanups
branch
from
cc450b2 to
9d92214
Compare
In particular, the backward- vs. forward-compatibility idea.
This is simpler, and the result can be easily converted to `String` if necessary. Also remove lots of `NvvmArch::` prefixes in the tests.
It's a more precise type -- these are static values. Also it avoids unnecessary allocations.
nnethercote
force-pushed
the
NvvmArch-cleanups
branch
from
9d92214 to
8a362f9
Compare
Collaborator
Author
|
@LegNeato I have updated this with several new commits. It's ready for review. |
LegNeato
requested changes
Nov 26, 2025
crates/nvvm/src/lib.rs
Outdated
| .chars() | ||
| .last() | ||
| .is_some_and(|c| c.is_ascii_alphabetic()) | ||
| !self.target_feature().ends_with(['f', 'a']) |
Contributor
There was a problem hiding this comment.
The previous logic was future-proof where this will be incorrect if NVIDIA adds another? A base variant is defined as not having a letter suffix at all.
Collaborator
Author
There was a problem hiding this comment.
Ok, I changed it to this:
!self.target_feature().ends_with(|c| char::is_ascii_alphabetic(&c))
8a362f9 to
593afc1
Compare
This is just a slightly less powerful version of `all_target_features`, one that always includes all the 'a' and 'f' variants for each level. It doesn't seem worth having.
nnethercote
force-pushed
the
NvvmArch-cleanups
branch
from
593afc1 to
8e78cd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NvvmArch's implementation can be simplified in various ways.