Install Clippy for a custom toolchain if missing

It already works for normal compilation, but after Rust-GPU/rust-gpu#505 I'd like to see a similar feature being implemented for clippy since right now it fails something like this:

error: 'cargo-clippy' is not installed for the toolchain 'nightly-2025-06-30-aarch64-apple-darwin'.
To install, run rustup component add --toolchain nightly-2025-06-30-aarch64-apple-darwin clippy
Error: BuildFailed

(Since cargo-gpu takes care of toolchain installation, I moved it over)

I double checked our code and it:

checks whether the toolchain is installed
if it is not:
- installs the toolchain with the default profile, which includes clippy
- installs extra components

We should probably check whether all components were installed of a set toolchain, and not just that you have the toolchain. And while I'm at it, we can merge the two install actions into one command, since rustup toolchain install accepts -c --components.

But apart from that, I don't see how you could end up in a situation where clippy is actually missing, except if you've ever manually ran rustup toolchain install nightly-2025-06-30-aarch64-apple-darwin --profile minimal explicitly with the minimal profile, since the default one includes clippy.

I certainly do not install nightly-2025-06-30 manually in CI and do not cache the corresponding directory either.

Here is an example CI run where you can also see the exact workflow that was used: https://github.com/nazar-pc/abundance/actions/runs/21829789170/job/62984572278

Very curious, # are my comments:

--- stderr
  # this is the first command which *should* be `rustup toolchain add nightly-2025-06-30`
  info: syncing channel updates for 'nightly-2025-06-30-x86_64-unknown-linux-gnu'
  info: latest update on 2025-06-30, rust version 1.90.0-nightly (35f603652 2025-06-29)
  info: downloading component 'cargo'
  info: downloading component 'rust-std'
  info: downloading component 'rustc'
  info: installing component 'cargo'
  info: installing component 'rust-std'
  info: installing component 'rustc'
  # this is the second command which *should* be `rustup components add --toolchain nightly-2025-06-30 rust-src rustc-dev llvm-tools`
  info: downloading component 'rust-src'
  info: installing component 'rust-src'
  info: downloading component 'rustc-dev'
  info: installing component 'rustc-dev'
  info: downloading component 'llvm-tools'
  info: installing component 'llvm-tools'
  # and we start building `rustc_codegen_spirv`
      Updating git repository `[https://github.com/Rust-GPU/rust-gpu//`](https://github.com/Rust-GPU/rust-gpu//%60)
      Updating crates.io index

But notice how the first command only installed cargo,rust-std,rustc and is missing clippy? I can only reproduce this behavior if I additionally pass --profile minimal, and cargo-gpu source code is definitely not passing that. I wonder if there's some env var that changes the default profile from "default" to "minimal"? Neither rustup docs on profiles nor env vars don't mention anything, nor does github show any special env vars being passed.

I think GitHub Actions might be installing minimal by default, which forces everything downstream to be minimal as well.

Since not everyone might be using clippy with rust-gpu either, do you think installing clippy explicitly on demand makes sense? Otherwise I'd add a clippy component explicitly (no need for rustfmt or rust-docs to be installed for rust-gpu's toolchain). In that case I'd actually say --profile minimal would be preferred.

I'm currently working on a PR to refactor our toolchain installation, planning to use --profile minimal and explicitly add clippy to the component list (removing rust-docs and rustfmt). Give me an hour or so

@nazar-pc

@nazar-pc please test cargo-gpu main, also includes the spirv-builder update

Worked great, thanks!

Navigation Menu

Repository navigation

Install Clippy for a custom toolchain if missing #136

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Install Clippy for a custom toolchain if missing #136

Description

Activity

Firestar99 commented on Feb 10, 2026

nazar-pc commented on Feb 10, 2026

Firestar99 commented on Feb 10, 2026

nazar-pc commented on Feb 10, 2026

Firestar99 commented on Feb 10, 2026

Firestar99 commented on Feb 10, 2026

nazar-pc commented on Feb 11, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions